Dojo

Bug in dojox/grid/_Grid

InternalError: “too much recursion” /dojox/grid/DataGrid.js

The issue appears to stem from dojox/grid/_View::hasVScrollBar() where it calls this.grid.update() here:

if(hadScroll !== this._hasVScroll){
    this.grid.update();
}

In this scenario, _Grid::update() has been set to _Grid::defaultUpdate(). The fix that I came up with is to update to

defaultUpdate: function(){
		// note: initial update calls render and subsequently this function.
		if(!this.domNode){return;}
		if(this.updating){
			if (this.invalidated) { // modification to fix recursive bug, this.invalidate not always defined
				this.invalidated.all = true;
			}
			return;
		}
		
		this.updating = true; // modification to fix recursive bug
		
		//this.edit.saveState(inRowIndex);
		this.lastScrollTop = this.scrollTop;
		this.prerender();
		this.scroller.invalidateNodes();
		this.setScrollTop(this.lastScrollTop);
		this.postrender();
		//this.edit.restoreState(inRowIndex);
		
		this.updating = false; // modification to fix recursive bug
	}

So, I guess my questions is: Is there a better way to fix this issue?